|
|
Close
|
11 |
|
Status |
Closed |
Ready to Review |
Assigned to |
-- |
mkor, tcwible |
|
|
|
mkor
Jun 22 2022 11:17
|
|
Edit
|
10 |
|
Comments/Attachments |
Long-term we might want to step away from using "toFixed" since it genuinely is written to round <= 0.5 down (as opposed to the expected < 0.5) in certain browsers due to how floating point values are stored behind the scenes. But this pre-emptive rounding in python will do the trick for now |
-- |
|
|
|
mkor
Jun 22 2022 11:12
|
|
Ready for Review
|
9 |
|
Status |
Ready to Review |
In progress |
Comments/Attachments |
tcwible I'm getting the expected 9.39 on the React side with this sample file, both before and after the "toFixed" call |
-- |
|
|
|
Restart
|
8 |
|
Status |
In progress |
Ready to Review |
Comments/Attachments |
Not quite, we did all the extra pieces in R, but I want you to debug/test the React-side of it to make sure this is working as expected here:
1655844181820.png |
-- |
|
|
|
mkor
Jun 21 2022 13:51
|
|
Ready for Review
|
7 |
|
Status |
Ready to Review |
In progress |
Comments/Attachments |
tcwible This appears to be resolved already in versions 1.5.16+ |
-- |
|
|
|
Edit
|
6 |
|
Comments/Attachments |
mkor Added placeholders in text for testing a fix for rounding. |
-- |
|
|
|
Edit
|
5 |
|
Comments/Attachments |
By-hand running of R2Cross R code results in 9.38512 (which will not round to 3.386). However, both values should round to 9.39. Checking that next. |
-- |
|
|
|
Edit
|
4 |
|
|
|
|
Start
|
3 |
|
Status |
In progress |
New |
Comments/Attachments |
Digging into the interface and I can confirm this issue. Working with Matthew next on determining the R-code rounding issue |
-- |
|
|
|
Edit
|
2 |
|
|
|
|
Submit
|
1 |
|
|